-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display complete info for an ontology class, including synonym types and axiom annotations #473
Comments
The actual info could be rendered in a number of different ways, I think the OLS gets this just right. It shows the important info front and center, and makes the advanced info (e.g equivalence axioms available to the side). Not sure if there is any js code we could reuse @simonjupp? |
IIRC, we have some stuff already for rendering col 16 artifacts from the owltools loader. https://github.com/geneontology/amigo/blob/master/javascript/lib/amigo/handlers/owl_class_expression.js Code needs to be modernized a bit... As well, there's a fair number of various renderers associated with the It would be good if we could coordinate on all of this. |
I think that may be fairly hardwired to annotation extensions. What I have in mind for rendering could be done entirely by logic-free mustache templates. The only question is on the rendering of xrefs and other hyperlinkable entities (see parallel monarch ticket), the desire behavior may depend on the context in which the component is deployed. Could be done with call backs, but I would be inclined to keep it simple: perhaps the embedding app can enrich the json with hyperlinks, and the render code can be dumb. |
The amigo c16 code is more to highlight that we're starting to get a lot of special little blobs that are requiring handling and it would be good to start narrowing it down a bit. Some things will be a a little annoying to do in AmiGO templates, but nothing that we haven't done before (mustache render, then injection). |
FYI for the more complex OWL axiom rendering OLS generates HTML snippets server side using an OWL HTML renderer developed by Nick Drummond many years ago https://github.com/co-ode-owl-plugins/ontology-browser/tree/master/owlhtml/src/main/java/org/coode/html/renderer |
Currently the amigo term info page is only showing a subset of information about a term. We lack some properties such as synonyms (the 4 synonym types are flattened into a single synonym field), and we lack axiom annotations (for example, definition xrefs and synonym xrefs). We also lack axiom constructs such as equivalent classes.
To achieve this, the plan is:
ontology_class
documents - Support obographs in ontology documents #474 (awaiting merge)The text was updated successfully, but these errors were encountered: