Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0: Error "Resolving ‘magit-insert-files-1’ template failed -- Cannot find definition" #8

Closed
dunmaksim opened this issue Jun 28, 2024 · 2 comments

Comments

@dunmaksim
Copy link

dunmaksim commented Jun 28, 2024

Hello!

Today me update magit-file-icons to version 2.0.0, and now I see this message on minibuffer and *Warnings* buffer:

Error (use-package): magit-file-icons/:config: Resolving ‘magit-insert-files-1’ template failed -- Cannot find definition

My settings:

(use-package magit-file-icons
  :ensure t
  :after magit
  :config
  (magit-file-icons-mode 1))

Emacs 29.3

@gekoke
Copy link
Owner

gekoke commented Jun 28, 2024

Hi!

v2.0.0 is a major version bump in order to accommodate breaking changes to Magit's internals (see #7). If you're not using a very recent version of Magit, this error is expected.

Your options include:

  1. updating magit to at least MELPA version magit-20240624
  2. using magit-file-icons at v1.x.x

magit-file-icons relies on the internal structure of the magit package looking a certain way, so it will break if any of that ever changes (which will, hopefully, be infrequently)

Let me know if this helps.

@dunmaksim
Copy link
Author

Yes, that works. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants