Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility #10

Closed
theanxy opened this issue Mar 21, 2014 · 2 comments
Closed

Fix accessibility #10

theanxy opened this issue Mar 21, 2014 · 2 comments

Comments

@theanxy
Copy link

theanxy commented Mar 21, 2014

The site is spreading front-end development anti-patterns such as IMG tags with no ALT attributes, poor HTML semantics, skipping Hx headings and much more. Please use WAI-ARIA to hide presentational elements from screen readers.

Attached is the output from Fangs:
chrome___fangs_-fangs___x-gif___http___geelen_github_io_x-gif___http___i_imgur_com_ikxh4e2_gif__and__x-gif__and_2014-03-20_1753-_amandaguerriero_s_library

@geelen
Copy link
Owner

geelen commented Mar 21, 2014

Yeah this was hacked up in a super rush before I got on a flight, and got a
fair bit more attention than I expected.

I think the x-gif tag should be as similar as possible to the img tag in
terms of semantics, and all the tags within it should be completely hidden.
Sound right?

This is my first polymer element too, so I'm not sure if there's a pattern
I can follow. Would be happy to receive any more feedback/PRs.

On Saturday, March 22, 2014, Wojtek Zając notifications@github.com wrote:

The site is spreading front-end development anti-patterns such as IMG tags
with no ALT attributes, poor HTML semantics, skipping Hx headings and much
more. Please use WAI-ARIA to hide presentational elements from screen
readers.

Attached is the output from Fangs:
[image:
chrome___fangs_-fangs___x-gif___http___geelen_github_io_x-gif___http___i_imgur_com_ikxh4e2_gif__and__x-gif__and_2014-03-20_1753-_amandaguerriero_s_library]https://f.cloud.github.com/assets/92843/2486424/6393842c-b126-11e3-94a2-9e681018340d.png


Reply to this email directly or view it on GitHubhttps://github.com//issues/10
.

@geelen
Copy link
Owner

geelen commented Mar 22, 2014

Started PR #11 to work on this - would love if you could work with me on fixing this @theanxy :)

@geelen geelen closed this as completed Mar 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants