Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced FastODS with SODS #8

Conversation

ideas-into-software
Copy link
Contributor

@juergen-albert @stbischof

As per request, due to licensing issue with FastODS, I have replaced it with SODS (https://github.com/miachm/SODS).
Except for features which SODS is currently missing, everything works as with previous version.

Missing features are:

  • no CRLF character support in cell for values which must be output on separate lines; in cells where multiple reference IDs are output this becomes one long string – equivalent of FastODS’s TextBuilder / Paragraph must be added to SODS, or at least respecting CRLF and outputting such on new lines;
  • no links
  • no ability to freeze row

SODS library was wrapped and added to local repository as there is no release version yet with proper OSGi manifest headers.

I’ve noticed Stefan is working on SODS project – there was a recent pull request from Stefan merged into SODS (https://github.com/miachm/SODS/commits/master). Are you perhaps working on adding those missing features to SODS or should I take care of this?

Michael H. Siemaszko added 4 commits January 31, 2023 10:34
 - Specialized EMF ODS resource

 - References traceable via IDs and (optionally) links

 - Additional export options

 - Additional metadata

 - Documentation

 - Various fixes & improvements


Signed-off-by: Michael H. Siemaszko <[email protected]>
Signed-off-by: Michael H. Siemaszko <[email protected]>
Signed-off-by: Michael H. Siemaszko <[email protected]>
 - Added support for links after having added this new feature to SODS
library

 - Added support for mapping tables

 - Various fixes & improvements

Signed-off-by: Michael H. Siemaszko <[email protected]>
@ideas-into-software
Copy link
Contributor Author

@juergen-albert @stbischof

Attached please find examples of generated ODS files - those three cases are explained in their file names.

Please clarify if having links compatible with Excel (please verify yourself - ODS files attached) still requires a separate exporter for Excel, or this is sufficient.

testBasicPackageExport11684183219405744071.addMappingTable-disabled&generateLinks-enabled.ods
testBasicPackageExport2348042832616144705.addMappingTable-enabled&generateLinks-disabled.ods
testBasicPackageExport13762410703655588523.addMappingTable-enabled&generateLinks-enabled.ods

emf-ods-exporter-sods

Signed-off-by: Michael H. Siemaszko <[email protected]>
@ideas-into-software
Copy link
Contributor Author

@juergen-albert @stbischof

Merge conflicts are resolved now, ready to merge.

Please clarify:

  1. If having links compatible with Excel (please verify yourself - ODS files attached) still requires a separate exporter for Excel, or this is sufficient
  2. Metadata related - if and how documentation @ type level should be handled (currently at field level only).
  3. Whether a separate CSV exporter is required - as discussed during 2023/01/31 meeting with @juergen-albert

@juergen-albert
Copy link
Contributor

Metadata related - if and how documentation @ type level should be handled (currently at field level only).

In the attached ODS, I added an example of how I think it could look like for the Family Metadata.
testBasicPackageExport11684183219405744071.addMappingTable-disabled.generateLinks-enabled.ods

Signed-off-by: Michael H. Siemaszko <[email protected]>
@ideas-into-software
Copy link
Contributor Author

ideas-into-software commented Apr 18, 2023

@juergen-albert "Metadata documentation improvements" commit contains required changes.

Attaching generated ODS files. There are two models used in the integration test - one of them, org.gecko.emf.osgi.example.model.basic does not have any documentation annotations.

testBasicPackageExport5213785929955836613.no-metadata-docs-in-model.ods
testUtilitiesPackageExport10368667694391926136.metadata-docs-in-model.ods

@juergen-albert juergen-albert merged commit a803f76 into geckoprojects-org:jakarta Apr 19, 2023
juergen-albert added a commit that referenced this pull request Jan 8, 2024
juergen-albert added a commit that referenced this pull request Jan 8, 2024
juergen-albert added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants