Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin Request] Toggle menu bar #1380

Open
ralf3u opened this issue Oct 30, 2024 · 10 comments
Open

[Plugin Request] Toggle menu bar #1380

ralf3u opened this issue Oct 30, 2024 · 10 comments

Comments

@ralf3u
Copy link

ralf3u commented Oct 30, 2024

Thanks to the geanylua-script https://github.com/xiota/geanylua-scripts/tree/main/toggle-menu-bar I wrote a step-by-step-description how to toggle menu bar: geany/geany#633 (comment). The problem is that it takes about 10 minutes to build the feature. For users it would be better to have a plugin like Toggle menu bar in the plugin manager. Then users could activate the checkbox next to the plugin Toggle menu bar in the plugin manager and could set a shortcut.

Forgot the shortcut?

  • If users forget the shortcut, there is the possibility to press Ctrl+Alt+P to open the preferences to look for the according shortcut in keybindings.
  • If the plugin would exist and if users forget the shortcut and don't know where to set shortcuts, I think that in short time search engines will give the solution, namely Ctrl+Alt+P to open the preferences to look for the according shortcut in keybindings.

Options
There are no options planed for this plugin.

Behavior
Once the menu bar is disabled by pressing the shortcut, the menu bar stays disabled even after a restart of Geany. The menu bar will appear again only if the shortcut will be pressed again.

History
2972 at geany and 1138 at geany-plugins were both closed but not fixed.

Official plugin
If this plugin is part of the official plugins, then issue number 633 at geany could be closed.

Remark
The toggle menu bar works absolutely perfect for me for years. I use the key F12 as shortcut to toggle the menu bar.

@ralf3u
Copy link
Author

ralf3u commented Oct 30, 2024

Simple question to the maintainers of geany-plugins:
Do you want a PR for the plugin Toggle menu bar, yes or no?

@elextr
Copy link
Member

elextr commented Oct 30, 2024

Just a reminder, the only maintainers are (as listed in MAINTAINER) the maintainer of individual plugins, so its only of interest if menu bar is something they might add to their plugin. Most plugins it isn't part of the plugin functionality, probably only the couple of miscellaneous collections of things are relevant if they are willing to accept a PR to add it.

@ralf3u
Copy link
Author

ralf3u commented Oct 31, 2024

Just a reminder, the only maintainers are (as listed in MAINTAINER) the maintainer of individual plugins, so its only of interest if menu bar is something they might add to their plugin.

It seems to be that there is a misunderstanding. My idea is that the plugin Toggle menu bar does only one single thing: to toggle the menu bar with a shortcut. It should not be part of an other plugin.

Do you think that if the plugin Toggle menu bar is programed that there is big chance that the plugin Toggle menu bar will be implemented in the official plugins like the plugin Save Actions or Spell Check? I ask this because if you say that there is less chance that this kind of plugin will be implemented in the official plugins, then there is no need to program the plugin.

@eht16
Copy link
Member

eht16 commented Nov 1, 2024

Such a plugin already exist (though seems abandoned) as mentioned in geany/geany#633. This could probably be used as a base.

Or, as @elextr suggested, have a look at the Addons plugin. Adding a new shortcut there to show/hide the menu bar is probably no big deal, is less work than creating a whole new plugin with all boilerplate and has good chances to be merged.

@ralf3u
Copy link
Author

ralf3u commented Nov 1, 2024

@eht16 The link of your last comment is wrong. I think you mean 633 at geany and not at geany-plugins. Maybe it would be good if you edit your last comment in that way that you just remove the hash.

@eht16
Copy link
Member

eht16 commented Nov 1, 2024

@eht16 The link of your last comment is wrong. I think you mean 633 at geany and not at geany-plugins. Maybe it would be good if you edit your last comment in that way that you just remove the hash.

Thanks, fixed.

@ralf3u
Copy link
Author

ralf3u commented Nov 1, 2024

Or, as @elextr suggested, have a look at the Addons plugin. Adding a new shortcut there to show/hide the menu bar is probably no big deal, is less work than creating a whole new plugin with all boilerplate and has good chances to be merged.

I don't like the idea that Toggle menu bar is part of an other plugin. I think that it is user-friendly when users see directly in the name of the plugin what the plugin is doing. And I think that mixed subjects in a name are not a good idea.

@xiota
Copy link
Contributor

xiota commented Nov 1, 2024

I wouldn't mind adding the hide menubar lua script to examples. However, I'm waiting for bug fix PR #1234 before doing anything else.

@ralf3u
Copy link
Author

ralf3u commented Nov 1, 2024

I wouldn't mind adding the hide menubar lua script to examples.

OK. Why not. It is less work than to program a whole plugin. It sounds simple and quite interesting. I didn't know that this was possible. The good thing is then that there is no need to copy and paste. So, users activate the plugin Lua Scripts in the Plugin Manager and then the only further step what need to be done is to define a shortcut in the Preferences in Keybindings in the Action "Lua Script" in "Toggle menu bar". Cool.

So, I intend to close this issue when PR 1234 will be closed.

@ralf3u
Copy link
Author

ralf3u commented Dec 6, 2024

I read several times in comments that a PR is welcome. There is the PR 1234. Could someone check and merge the PR to make Geany even better and to close this issue?

Please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants