Notebook notebooks/workflow_3_cascaded_mzi.ipynb has incorrect MZI parameters #677
Description
Describe the bug
The notebook notebooks/workflow_3_cascaded_mzi.ipynb is supposed to implement a filter from a published paper [1]. However, the delta lengths and orientations of the MZIs are incorrect.
To Reproduce
Running the notebook notebooks/workflow_3_cascaded_mzi.ipynb gives a design with incorrect delta lengths and MZI orientations. The notebook produces the following:
Expected behavior
The MZIs should look like the following:
Suggested fix
Input the correct delta lengths and use signed delta lengths for proper MZI orientation.
Versions
Modules
┏━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓
┃ Package ┃ version ┃ Path ┃
┡━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩
│ python │ 3.12.8 (main, Jan 14 2025, 22:49:14) [Clang │ <path> │
│ │ 19.1.6 ] │ │
│ gdsfactory │ 9.35.1 │ <path> │
│ devsim │ not installed │ │
│ femwell │ not installed │ │
│ gdsfactoryplus │ not installed │ │
│ gplugins │ 2.0.1 │ <path> │
│ kfactory │ 2.4.2 │ <path> │
│ lumapi │ not installed │ │
│ meep │ │ │
│ meow │ not installed │ │
│ ray │ not installed │ │
│ sax │ 0.16.6 │ <path> │
│ tidy3d │ 2.10.2 │ <path> │
│ vlsir │ not installed │ │
└────────────────┴────────────────────────────────────────────────┴──────────────────┘