Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tcell.KeyTAB be tcell.KeyHT? #746

Open
chrislalos opened this issue Aug 8, 2024 · 1 comment
Open

Should tcell.KeyTAB be tcell.KeyHT? #746

chrislalos opened this issue Aug 8, 2024 · 1 comment

Comments

@chrislalos
Copy link

Firstly, tyvm for tcell :)

Looking at the section in key.go (

tcell/key.go

Line 426 in 88b9c25

const (
), it appears to be faithfully copied from an ASCII spec. I was curious about the origin, and various blogs led me to Wikipedia which led me to some US Armed Forces specs, specifically MIL-STD-188C and MIL-STD-188-100. key.go matches the specs perfectly, except for Tab, where the specs say HT but key.go has KeyTAB. key.go does specify KeyVT for Vertical Tab which matches the spec, so a change to KeyHT would be internally consistent as well. And then KeyTAB = KeyHT could be added to an aliases section.

Sound good?

@gdamore
Copy link
Owner

gdamore commented Oct 6, 2024

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants