#5095 Lock the cluster to perform pipeline migration

Author: stroomdev66

stroom-pipeline/build.gradle

@@ -7,6 +7,8 @@ dependencies {
     implementation project(':stroom-data:stroom-data-store-api')
     implementation project(':stroom-docref')
     implementation project(':stroom-core-shared')
+    // Just for pipeline migration, remove after 7.10
+    implementation project(':stroom-cluster:stroom-cluster-lock-api')
     implementation project(':stroom-cluster:stroom-cluster-task-api')
     implementation project(':stroom-data:stroom-data-store-api')
     implementation project(':stroom-dictionary:stroom-dictionary-api')

stroom-pipeline/src/main/java/stroom/pipeline/PipelineStoreImpl.java

@@ -16,6 +16,7 @@
 
 package stroom.pipeline;
 
+import stroom.cluster.lock.api.ClusterLockService;
 import stroom.docref.DocRef;
 import stroom.docref.DocRefInfo;
 import stroom.docstore.api.AuditFieldFilter;
@@ -63,20 +64,22 @@ public PipelineStoreImpl(final StoreFactory storeFactory,
                              final PipelineSerialiser serialiser,
                              final Provider<ProcessorFilterService> processorFilterServiceProvider,
                              final Provider<ProcessorService> processorServiceProvider,
-                             final PipelineDataMigration pipelineDataMigration) {
+                             final PipelineDataMigration pipelineDataMigration,
+                             final ClusterLockService clusterLockService) {
         this.processorServiceProvider = processorServiceProvider;
         this.store = storeFactory.createStore(serialiser, PipelineDoc.TYPE, PipelineDoc.class);
         this.processorFilterServiceProvider = processorFilterServiceProvider;
         this.pipelineDataMigration = pipelineDataMigration;
 
         // TODO : Remove this code when we move past version 7.10
-        store.migratePipelines(data -> {
-            if (pipelineDataMigration.migrate(data)) {
-                return Optional.of(data);
-            } else {
-                return Optional.empty();
-            }
-        });
+        clusterLockService.lock("PIPELINE_MIGRATION", () ->
+                store.migratePipelines(data -> {
+                    if (pipelineDataMigration.migrate(data)) {
+                        return Optional.of(data);
+                    } else {
+                        return Optional.empty();
+                    }
+                }));
     }
 
     ////////////////////////////////////////////////////////////////////////

unreleased_changes/20250904_164826_926__5095.md

@@ -0,0 +1,60 @@
+* Issue **#5095** : Lock the cluster to perform pipeline migration to prevent other nodes clashing.
+
+
+```sh
+# ********************************************************************************
+# Issue title: Pipeline Mig ERROR
+# Issue link:  https://github.com/gchq/stroom/issues/5095
+# ********************************************************************************
+
+# ONLY the top line will be included as a change entry in the CHANGELOG.
+# The entry should be in GitHub flavour markdown and should be written on a SINGLE
+# line with no hard breaks. You can have multiple change files for a single GitHub issue.
+# The  entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
+# 'Fixed nasty bug'.
+#
+# Examples of acceptable entries are:
+#
+#
+# * Issue **123** : Fix bug with an associated GitHub issue in this repository
+#
+# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository
+#
+# * Fix bug with no associated GitHub issue.
+
+
+# --------------------------------------------------------------------------------
+# The following is random text to make this file unique for git's change detection
+# cRsUJz362xSx1re1lqXYbDZsLSsSNos3fIh7CYCnfJG4WbLFSeKV7jYkZpRFN9mDYjQfczijubaX7d1w
+# gYLSIhbkmxK2nofweYsUnSENg0MuLKALe2QiAYYWFRbqDQrzN4qDU4XFtO3PinDZiRGpQmcGAnjD4vSJ
+# ESgyR6aft8NxROC4qp7d0nzISstZSX4v5BfDz9z10qNOX9NJYXd4U0PPDJA0Wjf9exD8KyHw6WYZGXbG
+# YF9Mxz679Qwrmx9Vo9IPVXrgBKMHSI0dMKMNtxCEOS2eiumpqU5iEAzJtXs7CowSGcAPl9JIUwSOQZIo
+# uHuiTfEVroQv8oty20NNKR26KzvazxZAYnAtlBU8atlEOTSJAfvIWUSm1Uh88T6AZ3YCIXMBTfLAtWAQ
+# wdpT0uVzE12kb0ICAhj3NQVu1Gla7pECgENX8o5xvo3uNX4qGZ2JeOr8dY3AgulM2tzfZu6Bn6IV95G9
+# uvj2XCrUCIYxBW2muqJVVx99ZQLsVy3N7ajBLh0aMaJi6HKEqRdg2ODhCbHBdfSKMKWFS7vnG8mPzUHb
+# EZryg2dgekuVy2XTVkbXUNPAI2UjJHTz4clnmWnZKApAftYGJkz145x6HPNVd0GttziRBZhGbXbTdeg7
+# 1LEkU3SOgPTyhynIkDywr6OiAjXHgdynB9Fsu0CNyMUkHTdciQUXSZ8vxqgb6ikUp4bwi8FPInrLiCXX
+# ev3QP3m93gb9nRZrQWLOLlzrYxKXTMIeLvf7IUf5h6BeeV0nL7f09iVzRtaUtFVVwA8bUFuOMdxcm56c
+# QHc5mWhegcyMqjmiNgMjmsKinAJMosZ9Au6GZ3qLIobD3SaxWI2CRtHR0prqsrDshmfP3e1F3YiOwh3p
+# fuopZJ6DnF3cfKqwt6rSQyVrD8oHHz63NRmByQMhRFl519D7prRl9qmGFVMjBpOhXR0FhkQK0Z8hlpKY
+# DACu7PxU4iObGpIXa4NgBVdb4Ij1oQiPSzAALWIyga5tRi98iqI9Hvi2ovbGYhIGDk68UthB5XVIr8g0
+# 9bkO63gYJK87tZrmJXSUZ5rxKMcnqnocrJ78fNoCH9D14wgk2I0p7QUWxPVHXsxlLipgvtFo3pp1HtVc
+# ffLP2kT21cH07Spv31Hkf1VS1XZOLbYo96Wzl4EGL4i0XzUfqMjg9glQBBxOipMNURVkXZP9dIG9I1gS
+# bpUfxGoCCUc8ol4hHPttM3sCOjkypCyhaz0nMbTG8YpRBUSwf34wkvD185djhaUbiC74pcNMsRUUkole
+# dG2slPrETcANMqeZEeW2rmHq3vj3OYz5JbwPogTUo7ybpHP6ZVg8qA6zVHcqTY8GIlmhDboPArJMYyzb
+# ZWIZ2dpwmbpug4qQWe4UW1UpWk9Fv0L2b6hh2cGK2DqPZAWEnIlFm32xXJoo0lzHa3AcWGlGE5v3CkE3
+# 7PnGJBXt6mVvDEzMRZhPA01ahntymrOpuK8H3bKjkTdkvUA8jrdzOXSunloTsuH8DNAqOJiqEL7VpLhk
+# UsfHO16ZU0poBvveB8tp7gYUspK7K2X0LxKDspf3wYX1JAJ6KozTy2an3eh4qBpZkD31mJGg6EGmF6Ei
+# LXeQUZ8NwlJL3XE4mPJgWdC3NSicAS3424mMUVpC9XK5pC0hThxYNsrb3UPPoQGdptqqWqvKlYtQAxzE
+# Zh0nSk7wtOwoXKfML43pQhTc0JrgnoEIlCp9KvEJAlLCiLOrPic1F4ytKXvg16cBVb8ph6opBrAR6yBH
+# 4OVVkFpG3TVYxl1p6464P5tQl96TeqTUCCms7XXoOvTtyilEP9nU05zMRmRnmCYkTP5HnO5hvTmuBYj9
+# xv2Aiyex5PBbwqJxFNq5IFPOBAq7bkI5n8wi6SfZFjMLZLMhjgcTQezg6kACUczMgLy8JisIYSlEXXfu
+# sFVZjoRlMzjSVWVGP92rLVLi90DOfQzEeTKINZtSwpu0MSY8998Z7eq44XHKvCvX0d4l7kGjXpvrKalJ
+# TKIBNEGnho4WDx48YQyE5kBnf3oMgsowGnkr3JoSovb7d7ARddsBpAYyKh0BWb0nhOOyhC6yaULkscup
+# 31AMcxcvrZXSnNOZ6bCOi0G8Txj3beMFql2KhifMqxU7Dr1Sw9zLWtRGxHOtHExQ06mSftBd0PFyQuuq
+# Od5sRWgjlFEwdfbLA7HqErpDYsnMABJJYxLNYSOQsM9YqEFZ7QHJgD1daO2DbdYCbcm9kQTovuPs4gvE
+# Vjkmdwcz63K3hYMufIcj5UafMU7AgT2IYRhujvtmQOJH7wukAtZIUdj5HTzZ9Rpmv7MqiIXnFMXbmgjz
+# Ef2swVvz14aMFAYPhwjggQcADtYQBBxRKXJcdYfsKllGN00izPtN0gYMpKqmkZNcPwPqlZ2G34c3m5YK
+# --------------------------------------------------------------------------------
+
+```