Skip to content

Commit 0704df0

Browse files
committed
Merge commit 'refs/pull/5083/head' of github.com:gchq/stroom
2 parents f8c3a23 + 780387e commit 0704df0

File tree

19 files changed

+279
-68
lines changed

19 files changed

+279
-68
lines changed

stroom-analytics/stroom-analytics-impl/src/main/java/stroom/analytics/impl/AnalyticDataStores.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ public ResultPage<ResultStoreInfo> find(final FindResultStoreCriteria criteria)
320320
list.add(new ResultStoreInfo(
321321
new SearchRequestSource(SourceType.TABLE_BUILDER_ANALYTIC,
322322
docRef,
323-
null),
323+
null, null),
324324
searchRequest.getKey(),
325325
null,
326326
analyticRuleDoc.getCreateTimeMs(),

stroom-analytics/stroom-analytics-impl/src/main/java/stroom/analytics/impl/ScheduledQueryAnalyticExecutor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,9 @@ boolean process(final AnalyticRuleDoc analytic,
287287
errorConsumer,
288288
expressionPredicateFactory,
289289
mapper);
290-
mapper = ConditionalFormattingMapper.create(
290+
291+
mapper = ConditionalFormattingMapper.create(resultRequest.getSourceComponentId(),
292+
resultRequest.getSourceComponentName(),
291293
columns,
292294
tableSettings.getConditionalFormattingRules(),
293295
expressionContext.getDateTimeSettings(),

stroom-app/src/test/java/stroom/search/AbstractSearchTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,14 @@ public static void testInteractive(
9191
for (final String componentId : componentIds) {
9292
final TableSettings tableSettings = tableSettingsCreator.apply(extractValues);
9393

94-
final ResultRequest tableResultRequest = new ResultRequest(componentId,
94+
final ResultRequest tableResultRequest = new ResultRequest(componentId, null,
9595
Collections.singletonList(tableSettings),
9696
null,
9797
null,
9898
null,
9999
ResultRequest.ResultStyle.TABLE,
100100
Fetch.CHANGES,
101+
null,
101102
null);
102103
resultRequests.add(tableResultRequest);
103104
}

stroom-app/src/test/java/stroom/search/TestEventSearch.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,14 @@ private void test(final ExpressionOperator.Builder expressionIn,
101101
for (final String componentId : componentIds) {
102102
final TableSettings tableSettings = createTableSettings(index, extractValues);
103103

104-
final ResultRequest tableResultRequest = new ResultRequest(componentId,
104+
final ResultRequest tableResultRequest = new ResultRequest(componentId, null,
105105
Collections.singletonList(tableSettings),
106106
null,
107107
null,
108108
null,
109109
ResultRequest.ResultStyle.TABLE,
110110
Fetch.CHANGES,
111+
null,
111112
null);
112113
resultRequests.add(tableResultRequest);
113114
}

stroom-app/src/test/java/stroom/search/TestTagCloudSearch.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,13 +106,14 @@ void test() {
106106
"2016-01-02T00:00:00.000Z");
107107
final Query query = Query.builder().dataSource(indexRef).expression(expression.build()).build();
108108

109-
final ResultRequest tableResultRequest = new ResultRequest(componentId,
109+
final ResultRequest tableResultRequest = new ResultRequest(componentId, null,
110110
Collections.singletonList(tableSettings),
111111
null,
112112
null,
113113
null,
114114
ResultRequest.ResultStyle.TABLE,
115115
Fetch.CHANGES,
116+
null,
116117
null);
117118

118119
final List<ResultRequest> resultRequests = Collections.singletonList(tableResultRequest);

stroom-core-client/src/main/java/stroom/dashboard/client/embeddedquery/EmbeddedQueryPresenter.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ private void run(final boolean incremental,
575575

576576
// Start search.
577577
final DashboardContext dashboardContext = getDashboardContext();
578-
queryModel.startNewSearch(
578+
queryModel.startNewSearch(getComponentConfig().getId(), getComponentConfig().getName(),
579579
replaced,
580580
dashboardContext.getParams(),
581581
dashboardContext.getResolvedTimeRange(),
@@ -851,7 +851,9 @@ public QueryResultTablePresenter getCurrentTablePresenter() {
851851

852852
@Override
853853
public void onContentTabVisible(final boolean visible) {
854-
currentTablePresenter.onContentTabVisible(visible);
854+
if (currentTablePresenter != null) {
855+
currentTablePresenter.onContentTabVisible(visible);
856+
}
855857
}
856858

857859
public interface EmbeddedQueryView extends View, RequiresResize {

stroom-core-client/src/main/java/stroom/dashboard/client/table/TablePresenter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1010,6 +1010,7 @@ public void read(final ComponentConfig componentConfig) {
10101010
tableResultRequest = tableResultRequest
10111011
.copy()
10121012
.componentId(componentConfig.getId())
1013+
.tableName(componentConfig.getName())
10131014
.build();
10141015

10151016
final ComponentSettings settings = componentConfig.getSettings();

stroom-core-client/src/main/java/stroom/query/client/presenter/QueryEditPresenter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,8 @@ private void run(final boolean incremental,
396396

397397
// Start search.
398398
queryModel.startNewSearch(
399+
null,
400+
null,
399401
editorPresenter.getText(),
400402
null, //getDashboardContext().getCombinedParams(),
401403
queryToolbarPresenter.getTimeRange(),

stroom-core-client/src/main/java/stroom/query/client/presenter/QueryModel.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ public void reset(final DestroyReason destroyReason) {
147147
/**
148148
* Begin executing a new search using the supplied query expression.
149149
*/
150-
public void startNewSearch(final String query,
150+
public void startNewSearch(final String componentId,
151+
final String componentName,
152+
final String query,
151153
final List<Param> params,
152154
final TimeRange timeRange,
153155
final boolean incremental,
@@ -173,6 +175,8 @@ public void startNewSearch(final String query,
173175
.searchRequestSource(
174176
SearchRequestSource
175177
.builder()
178+
.componentId(componentId)
179+
.componentName(componentName)
176180
.sourceType(sourceType)
177181
.ownerDocRef(queryDocRef)
178182
.build())

stroom-dashboard/stroom-dashboard-impl/src/main/java/stroom/dashboard/impl/SearchRequestMapper.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,8 @@ private List<ResultRequest> mapResultRequests(final DashboardSearchRequest searc
148148

149149
final ResultRequest copy = ResultRequest.builder()
150150
.componentId(tableResultRequest.getComponentId())
151+
.searchRequestSource(searchRequest.getSearchRequestSource())
152+
.tableName(tableResultRequest.getTableName())
151153
.addMappings(tableResultRequest.getTableSettings())
152154
.requestedRange(tableResultRequest.getRequestedRange())
153155
.resultStyle(ResultStyle.TABLE)

0 commit comments

Comments
 (0)