Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CombinedConcept URI #734

Open
nichtich opened this issue Sep 27, 2024 · 3 comments
Open

Remove CombinedConcept URI #734

nichtich opened this issue Sep 27, 2024 · 3 comments

Comments

@nichtich
Copy link
Member

nichtich commented Sep 27, 2024

We introduced the non-standard URI http://rdf-vocabulary.ddialliance.org/xkos#CombinedConcept to check whether a concept is a combined concept and to show an icon in this case. We should better remove this non-existing URI (after is has been removed from our concept data) and check for existence of memberSet, memberList, memberChoice instead. Unfortunately the URI is already used in multiple modules.

@stefandesu
Copy link
Member

Any particular reason for this change? Is the plan to change all our concept data, and what about those where we can't deconstruct which other "members" a combined concept consists of?

@stefandesu
Copy link
Member

Sorry, didn't mean to close.

@stefandesu stefandesu reopened this Sep 27, 2024
@nichtich
Copy link
Member Author

Any particular reason for this change?

Cleanup of JSKOS. At the moment http://rdf-vocabulary.ddialliance.org/xkos#CombinedConcept is not documented or but works. Concepts with memberSet not marked as combined, are not highlighted. Maybe extend check to also look whether any of memberSet, memberList, memberChoice is a non-empty array?

Is the plan to change all our concept data, and what about those where we can't deconstruct which other "members" a combined concept consists of?

Adding memberSet: [ null ] should do, but I guess this issue is a low-priority cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants