Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Login issue where the password field does not initially accept the 8 characters #229

Open
1 task
gbowne1 opened this issue May 25, 2023 · 9 comments
Labels
backend This is a backend issue or PR bug Something isn't working devops this is a devops related feature or issue or PR good first issue Good for newcomers help wanted Extra attention is needed high-priority medium-complexity This issue is medium complexity tech-debt This needs refactoring or improvement

Comments

@gbowne1
Copy link
Owner

gbowne1 commented May 25, 2023

Describe the Bug

This may or may not be a thing, but I am getting a minor bug where I am entering the test user's credentials.

Initially when I enter the password, it doesn't like to accept the password and I get the red border and it says Password must be 8 characters, and in this case the test users' password is totally 10 characters long.

This happens Especially if I use the test user's saved creds from the browser.

This also is sometimes intermittent. It works totally if I have been to the page before.

I have to go click on Login for it to actually recognize the 10 character password as the right length.

once the user gets to the 8th ~ 9th character in their entry the field the red border and warning should dissapear as well as not immediately appear when using a saved item.

As you can see in the screen shot, there is totally 10 characters and the border/warning still appears.

Steps to Reproduce

Start the development server by

cd to /client
run npm start

and in another terminal
cd to /server

wait for the dev server to start.

Get to the login screen and try entering the test users' creds. you should see the screenshot below.

Screenshots

Screenshot 2023-05-25 at 15-24-43 React Social Media App

Which device are you using?

Linux VM Server

Which operating system are you using?

Linux x64, Debian Base

Which browser are you using?

Firefox 112

Additional Context

No response

Contribute

  • I am willing to contribute and submit a pull request
@gbowne1 gbowne1 added bug Something isn't working help wanted Extra attention is needed labels May 25, 2023
@gbowne1 gbowne1 added this to the Front End milestone May 25, 2023
@gbowne1 gbowne1 removed this from the Front End milestone Jun 5, 2023
@manuel12 manuel12 self-assigned this Jun 8, 2023
@manuel12
Copy link
Collaborator

manuel12 commented Jun 8, 2023

Will investigate this.

@manuel12 manuel12 added this to the User Authentication milestone Jun 8, 2023
@manuel12
Copy link
Collaborator

manuel12 commented Jun 8, 2023

@gbowne1 Is this currently happening? I'm having difficulty trying to reproduce the issue :/

Just to explain how the current functionality is now, after using now front-end and back-end:

  • localStorage is not used anymore for storing testuser credentials, these are stored in the backend db by default when the db is created, hence why these credentials are always available.
  • The validation is only run when the submit button(login/register) is pressed, so right now functionality is not that the red warning label around inputs will automatically disappear if say, you have 7 characters in password input and then you add an 8th, in this case red label will remain. Instead once you click login/register the red label will disappear, as a new validation will be ran. This is to prevent all inputs being red from the beginning, because if we run validation when page is loaded and all inputs are empty then all inputs will be red.

In any case I will keep trying to reproduce the issue and fix it if I get it, if there's anything more I can do to reproduce please write me here in a comment :)

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 8, 2023

it only happens sometimes. I have the test creds saved in my browser. When applied it automatically turns the field red like shown. If I go back through, like refresh, log out, then try logging in again, this does not happen. It's intermittent.

@gbowne1 gbowne1 added needs-testing This needs testing medium-complexity This issue is medium complexity labels Jun 8, 2023
@manuel12
Copy link
Collaborator

manuel12 commented Jun 8, 2023

I will add an automated test that checks this, this way anytime anyone runs the e2e tests this will be checked, adn we will catch it if happens again.

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 8, 2023

Good idea. Just curious that a ten character autocompleted password would turn it red and display the error.

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 6, 2023

I still have not been able to nail down whats causing this either.

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 31, 2023

@manuel12 have we solved this or is this stil pretty much a non issue?

@manuel12
Copy link
Collaborator

manuel12 commented Nov 1, 2023

@manuel12 have we solved this or is this stil pretty much a non issue?

Need to check it again: I remember in the past I managed to reproduce this in Firefox when the browser autocompleted your password. I will look into this soon.

@gbowne1
Copy link
Owner Author

gbowne1 commented Nov 1, 2023

Ok great thanks @manuel12

@gbowne1 gbowne1 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers backend This is a backend issue or PR high-priority medium-complexity This issue is medium complexity tech-debt This needs refactoring or improvement devops this is a devops related feature or issue or PR and removed bug Something isn't working help wanted Extra attention is needed needs-testing This needs testing medium-complexity This issue is medium complexity labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This is a backend issue or PR bug Something isn't working devops this is a devops related feature or issue or PR good first issue Good for newcomers help wanted Extra attention is needed high-priority medium-complexity This issue is medium complexity tech-debt This needs refactoring or improvement
Projects
Development

No branches or pull requests

2 participants