Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ruby File.exists with File.exist and tweak tutorial #529

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Aug 30, 2024

🦟 Bug fix

While testing the logging tutorial , I ran into an issue executing:

gz log record --force --file tutorial.tlog

The ruby File.exists() function was removed in 3.2.0, which is the version in Ubuntu Noble. I updated the code and also used snippet in the tutorial.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero merged commit 2ddd4c8 into gz-transport14 Sep 2, 2024
11 checks passed
@caguero caguero deleted the ionic_logging_tutorial_fix branch September 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants