Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up namespaces #502

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Clean up namespaces #502

wants to merge 3 commits into from

Conversation

mjcarroll
Copy link
Contributor

Similar to what I've done in other places.

  • Use concatenated namespaces where possible.
  • Eliminate some uses of using namespace in cc files.
  • Add closing comments on namespaces and #ifdefs

@mjcarroll mjcarroll requested a review from caguero as a code owner May 16, 2024 13:09
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label May 16, 2024
caguero
caguero previously approved these changes May 16, 2024
View reviewed changes
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@caguero caguero dismissed their stale review September 6, 2024 20:16

Let's do another review after the retarget

@azeey azeey removed the beta Targeting beta release of upcoming collection label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @caguero @azeey