Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VERSION_GREATER_EQUAL in cmake logic #2418

Merged
merged 1 commit into from
May 30, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Small improvement to cmake logic

Summary

While updating cmake logic as part of gazebosim/gz-cmake#350, I noticed a version comparison using STRGREATER when VERSION_GREATER_EQUAL looks more appropriate to me, since the feature was added in cmake 3.22.

cc @traversaro who added this in #1764

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from mjcarroll as a code owner May 29, 2024 10:58
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 29, 2024
@traversaro
Copy link
Contributor

traversaro commented May 29, 2024

cc @traversaro who added this in #1764

Thanks for noticing! Yes, I guess I was just using something old out of habit. actually that was required at the time as we supporting also older versions of CMake.

@traversaro
Copy link
Contributor

Yes, I guess I was just using something old out of habit. actually that was required at the time as we supporting also older versions of CMake.

Actually not, that operator is available since CMake 3.7: https://cmake.org/cmake/help/v3.10/command/if.html , so it was perfectly fine to use it also back then.

@scpeters scpeters merged commit 3c52690 into ign-gazebo6 May 30, 2024
8 of 10 checks passed
@scpeters scpeters deleted the scpeters/fortress_version_greater_equal branch May 30, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants