-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joint Force-Torque Sensor #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that this is a draft, anyhow I just made some comments
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Devansh <[email protected]>
Signed-off-by: Devansh <[email protected]>
Signed-off-by: Devansh <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 75.52% 75.90% +0.37%
==========================================
Files 25 27 +2
Lines 2644 2747 +103
==========================================
+ Hits 1997 2085 +88
- Misses 647 662 +15
Continue to review full report at Codecov.
|
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCO is failing, but we can fix that when merging the PR.
if (frame == "child") | ||
{ | ||
EXPECT_EQ((rotChildInSensor.Inverse() * force) + forceNoiseMean, | ||
ignition::msgs::Convert(msg.force())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer to get to the expectations on a test in a different way from the source code's implementation. For example, I think this test doesn't really help us find problems with the implementation:
// Code
int sum(int _a, int _b)
{
return _a * _b;
}
// Test
EXPECT_EQ(a * b, sum(a, b));
A better test would be:
// Values obtained with a calculator
EXPECT_EQ(3, sum(1, 2));
I don't think the current test needs to be changed. Just a general comment.
Signed-off-by: Michael Carroll <[email protected]>
🎉 New feature
Closes #25
Summary
Joint force-torque sensor implementation.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸