Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally use cmake_path on cmake < 3.20 #424

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Fixes #423

Summary

This will conditionally use cmake_path if it is available, otherwise use multiple CMake functions to get the same behavior. Note that on the forward port, we can drop the alternate path (gazebosim/gz-cmake#350)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from caguero as a code owner January 29, 2024 16:36
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea68ca0) 97.67% compared to head (dd2ef92) 97.67%.
Report is 1 commits behind head on gz-msgs10.

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-msgs10     #424   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll self-assigned this Jan 29, 2024
@caguero caguero merged commit b35b9fd into gz-msgs10 Feb 3, 2024
15 checks passed
@caguero caguero deleted the mjcarroll/cmake_version branch February 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
2 participants