From 8b4f417ae09ce2f6d3162cebbed9097bd75bb58a Mon Sep 17 00:00:00 2001 From: pxalcantara Date: Tue, 30 Jun 2020 21:11:53 -0300 Subject: [PATCH] Remove individual mutable methods for Roll, Pitch, Yaw. Signed-off-by: pxalcantara --- include/ignition/math/Pose3.hh | 25 ------------------------- src/Pose_TEST.cc | 2 +- 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/include/ignition/math/Pose3.hh b/include/ignition/math/Pose3.hh index 01707f0e6..5ab512cbd 100644 --- a/include/ignition/math/Pose3.hh +++ b/include/ignition/math/Pose3.hh @@ -436,15 +436,6 @@ namespace ignition return this->q.Roll(); } - /// \brief Get the mutable Roll value of the rotation. - /// \return Roll value of the orientation. - /// \note The return is made by value since - /// Quaternion.Roll() is already a reference. - public: inline T &Roll() - { - return this->q.Roll(); - } - /// \brief Get the Pitch value of the rotation. /// \return Pitch value of the orientation. /// \note The return is made by value since @@ -454,13 +445,6 @@ namespace ignition return this->q.Pitch(); } - /// \brief Get the mutable Pitch value of the rotation. - /// \return Pitch value of the orientation. - public: inline T &Pitch() - { - return this->q.Pitch(); - } - /// \brief Get the Yaw value of the rotation. /// \return Yaw value of the orientation. /// \note The return is made by value since @@ -470,15 +454,6 @@ namespace ignition return this->q.Yaw(); } - /// \brief Get the mutable Yaw value of the rotation. - /// \return Yaw value of the orientation. - /// \note The return is made by value since - /// Quaternion.Yaw() is already a reference. - public: inline T &Yaw() - { - return this->q.Yaw(); - } - /// \brief Stream insertion operator /// \param[in] _out output stream /// \param[in] _pose pose to output diff --git a/src/Pose_TEST.cc b/src/Pose_TEST.cc index ad7b361ed..a41c2840b 100644 --- a/src/Pose_TEST.cc +++ b/src/Pose_TEST.cc @@ -183,7 +183,7 @@ TEST(PoseTest, ConstPoseElements) } ///////////////////////////////////////////////// -TEST(PoseTest, MutablePoseElements) +TEST(PoseTest, SetPoseElements) { math::Pose3d pose(1, 2, 3, 1.57, 1, 2); EXPECT_DOUBLE_EQ(pose.X(), 1);