Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gz-gui to use new message generation pipeline #541

Closed
wants to merge 1 commit into from
Closed

Update gz-gui to use new message generation pipeline #541

wants to merge 1 commit into from

Conversation

mjcarroll
Copy link
Contributor

Allows gz-gui to take advantage of the new message generation pipeline in gazebosim/gz-msgs#339

@mjcarroll mjcarroll requested a review from jennuine as a code owner May 30, 2023 16:14
@mjcarroll mjcarroll mentioned this pull request May 30, 2023
Merged
5 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #541 (94d1586) into main (94d1586) will not change coverage.
The diff coverage is n/a.

❗ Current head 94d1586 differs from pull request most recent head 0103643. Consider uploading reports for the commit 0103643 to get more accurate results

@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files          45       45           
  Lines        5038     5038           
=======================================
  Hits         3441     3441           
  Misses       1597     1597

jennuine
jennuine reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but CI is failing

@mjcarroll
Copy link
Contributor Author

CI is failing

Depends on gazebosim/gz-msgs#339 being merged and released, so expected for now

@mjcarroll mjcarroll added the needs upstream release Blocked by a release of an upstream library label May 30, 2023
@mjcarroll mjcarroll closed this Jul 26, 2023
@mjcarroll mjcarroll deleted the mjcarroll/message_generation_pipeline branch July 26, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine left review comments

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @jennuine