Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #402: Replace exec_program with execute_process #427

Merged
merged 2 commits into from
May 3, 2024
Merged

Backport #402: Replace exec_program with execute_process #427

merged 2 commits into from
May 3, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 3, 2024

🦟 Bug fix

Fixes gazebosim/gz-plugin#144

Summary

Backports #402 with an additional fix in fb83186

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey and others added 2 commits May 2, 2024 22:42
@azeey @scpeters
Replace exec_program with execute_process (gazebosim#402)
777a64e 
Signed-off-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@azeey
Remove additional exec_program
fb83186 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested review from j-rivero and scpeters as code owners May 3, 2024 03:47
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels May 3, 2024
@azeey azeey merged commit 2931ba3 into gazebosim:ign-cmake2 May 3, 2024
9 checks passed
@azeey azeey deleted the replace_exec_program branch May 3, 2024 16:40
@azeey azeey mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @mjcarroll