URI decode bottle filename before uploading #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #208, fixing failed upload of [email protected] bottle. Signed-off-by: Steve Peters <[email protected]>
|
Corresponding PR for chef-code in packages machine https://github.com/osrf/chef-osrf/pull/40 |
|
testing with deb build: |
upload worked too: |
|
rebuilding [email protected] bottles in osrf/homebrew-simulation#1150
I'll post the uploader job result after it runs |
it works!
|
nice! |
j-rivero
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bottles for
[email protected]were rebuilt in osrf/homebrew-simulation#1148, but they failed to upload:I had previously attempted to fix a related problem in #208, but it needs a follow-up here, which is to URI decode the filename specified in the bottle son before upload, to match the filename created in the bottle creator script. This uses the
urlencode -dcommand from thegridsite-clientsapt package.As an aside, this failed upload is motivation to improve the GitHub actions workflow to test uploaded bottles before merging an osrf/homebrew-simulation PR (osrf/homebrew-simulation#1139).
I have downloaded the bottles from this job and can upload manually, but I was hoping to retry the failed uploader job after merging this to master to confirm that it works.