Replace osrf-migration token by osrfbuild-token in bottle_job_builder #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… job Signed-off-by: Jose Luis Rivero <[email protected]>
|
I'll find an opportunity to test this |
|
build bottle |
lol, wrong PR |
I deployed the DSL from this branch: I also manually configured the triggered builder job to use this release-tools branch and started a bottle build for osrf/homebrew-simulation#2890 |
|
it works! I'll revert the configuration and approve |
|
scpeters
approved these changes
Nov 20, 2024
|
Thanks for the testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing the osrf-migration token I noticed that it is being used in bottle_job_builder for authenticating the
hubcli . We need it even if there are no push/clone operations involved, otherwise thehubcli is asking for credentials.This PR changes the osrf-migration user to use existing osrfbuild token.