Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication of code in the various plot_smooth() methods #308

Open
gavinsimpson opened this issue Aug 10, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@gavinsimpson
Copy link
Owner

Intentionally, I have duplicated a lot of code in the various plot_smooth() internal methods, waiting until things had settled down a bit with the package before attempting any sort of code de-duplication or clean up.

With only the bs = "mrf" basis currently not supported, time is ripe to reduce the duplication across the plot_smooth() methods, such that I can use a single prepare_smooth_plot() across all the methods.

Investigate the feasibility of doing this and implement.

@gavinsimpson gavinsimpson added this to the 0.10 milestone Aug 10, 2024
@gavinsimpson gavinsimpson self-assigned this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant