Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update draw.basis so that it works for bivariate (and higher dimension) smooths #151

Open
1 of 3 tasks
gavinsimpson opened this issue Mar 17, 2022 · 1 comment
Open
1 of 3 tasks
Labels
bug Something isn't working enhancement New feature or request plotting
Milestone

Comments

@gavinsimpson
Copy link
Owner

gavinsimpson commented Mar 17, 2022

Need plotting code for

@gavinsimpson gavinsimpson added bug Something isn't working enhancement New feature or request plotting labels Mar 17, 2022
@gavinsimpson gavinsimpson added this to the 0.8 milestone Mar 17, 2022
@gavinsimpson gavinsimpson modified the milestones: 0.8, 0.9 Jan 26, 2023
@gavinsimpson
Copy link
Owner Author

gavinsimpson commented Jan 4, 2024

There's also the additional problem of what to do with factor-by smooths in this setting. Could facet on ~ .by + .bf? But then what happens with the labeller (prefix_label_both())?

At the moment, if there is a factor by associated with the smooth the code just facets on the by variable and not on the basis function, so you'll get multiple surfaces on top of one another, it it works at all.

Might just be best to not draw the basis functions for each level of the .by factor - they're all the same anyway...

@gavinsimpson gavinsimpson modified the milestones: 0.9, 0.10 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request plotting
Projects
None yet
Development

No branches or pull requests

1 participant