Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gatsby-theme-i18n does not honor prefixDefault param in generated alternate links #126

Open
olivier-lacroix opened this issue May 27, 2021 · 0 comments · May be fixed by #127
Open

gatsby-theme-i18n does not honor prefixDefault param in generated alternate links #126

olivier-lacroix opened this issue May 27, 2021 · 0 comments · May be fixed by #127

Comments

@olivier-lacroix
Copy link

Hello there,

The alternate link for the default locale is always generated without prefix, irrespective of the prefixDefault parameter.

ie, with prefixDefault set to true, the theme generates

    <link data-react-helmet="true" rel="alternate" hrefLang="en" href="https://www.domain.com/about/" />
    <link data-react-helmet="true" rel="alternate" hrefLang="fr" href="https://www.domain.com/fr/about/" />

instead of

    <link data-react-helmet="true" rel="alternate" hrefLang="en" href="https://www.domain.com/en/about/" />
    <link data-react-helmet="true" rel="alternate" hrefLang="fr" href="https://www.domain.com/fr/about/" />
@olivier-lacroix olivier-lacroix linked a pull request May 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefix alternate links based on theme option olivier-lacroix/themes
1 participant
@olivier-lacroix