Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seems gatsby-plugin-s3 deploy always sets ErrorDocument to 404.html #365

Open
peteryhwong opened this issue Oct 19, 2022 · 2 comments · Fixed by #369 · May be fixed by #454
Open

Seems gatsby-plugin-s3 deploy always sets ErrorDocument to 404.html #365

peteryhwong opened this issue Oct 19, 2022 · 2 comments · Fixed by #369 · May be fixed by #454

Comments

@peteryhwong
Copy link

peteryhwong commented Oct 19, 2022 •
edited
Loading

Seems when we run gatsby-plugin-s3 deploy an putBucketWebsite is sent and hardcodes 404.html to be ErrorDocument even if the targeted s3 bucket is not configured to use 404.html as ErrorDocument.

https://github.com/jariz/gatsby-plugin-s3/blob/9365136039514771d03f965d4f240f55fc7722e7/gatsby-plugin-s3/src/bin.ts#L215
@peteryhwong peteryhwong changed the title Seems gatsby-plugin-s3 deploy always set forcibly ErrorDocument to 404.html Seems gatsby-plugin-s3 deploy always sets ErrorDocument to 404.html Oct 19, 2022
@YoshiWalsh
Copy link
Collaborator

YoshiWalsh commented Oct 19, 2022 •
edited
Loading

I'll happily review a PR that makes this configurable. Is there a particular reason why you want your ErrorDocument to be called something else though? The easiest fix here is to call your error document 404.html.

@peteryhwong peteryhwong mentioned this issue Oct 30, 2022
Merged
@peteryhwong
Copy link
Author

Thanks @JoshuaWalsh . See #369 a PR for making this configurable

@YoshiWalsh YoshiWalsh reopened this Mar 26, 2023
@peteryhwong peteryhwong linked a pull request Jun 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@YoshiWalsh @peteryhwong