Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UDS path on Windows #71

Open
5 tasks
mostafa opened this issue Dec 4, 2023 · 0 comments
Open
5 tasks

Fix UDS path on Windows #71

mostafa opened this issue Dec 4, 2023 · 0 comments
Labels
enhancement New feature or request epic
Milestone

Comments

@mostafa
Copy link
Member

mostafa commented Dec 4, 2023

Currently the UDS path is set to /tmp/gatewayd-plugin-cache.sock, which is not accessible in Windows, hence the plugin fails to run and exists abruptly. The current workaround is to set the path to the current directory, so that the UDS file is created relative to GatewayD, for example METRICS_UNIX_DOMAIN_SOCKET=.\gatewayd-plugin-cache.sock. This helps run the plugin, yet it won't remove the UDS file, hence the next run of the plugin will fail. The following fixes should be made to the plugin to work smoothly on Windows:

  • Find a suitable path for UDS file (like %temp% or similar)
  • Remove UDS file on cleanup
  • Provide a separate plugin config file for Windows, like gatewayd_plugin_windows.yaml
  • Have gatewayd plugin install pick up the Windows config file (for Windows builds)
  • Have gatewayd plugin init generate plugins config file suitable for Windows
@mostafa mostafa added the enhancement New feature or request label Dec 4, 2023
@mostafa mostafa added the epic label Dec 4, 2023
@mostafa mostafa added this to the v0.2.x milestone Dec 4, 2023
@mostafa mostafa moved this from ✨ New to 📋 Backlog in GatewayD Core Public Roadmap Dec 4, 2023
@mostafa mostafa moved this from 🆕 New to 📋 Backlog in Plugins Public Roadmap Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant