Skip to content

Commit 687226d

Browse files
authored
The upd_sink and dist_sink files have been modified to address Passed by value warnings. (#3520)
1 parent f2a9dec commit 687226d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

include/spdlog/sinks/dist_sink.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class dist_sink : public base_sink<Mutex> {
2424
public:
2525
dist_sink() = default;
2626
explicit dist_sink(std::vector<std::shared_ptr<sink>> sinks)
27-
: sinks_(sinks) {}
27+
: sinks_(std::move(sinks)) {}
2828

2929
dist_sink(const dist_sink &) = delete;
3030
dist_sink &operator=(const dist_sink &) = delete;

include/spdlog/sinks/udp_sink.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ template <typename Mutex>
3636
class udp_sink : public spdlog::sinks::base_sink<Mutex> {
3737
public:
3838
// host can be hostname or ip address
39-
explicit udp_sink(udp_sink_config sink_config)
39+
explicit udp_sink(const udp_sink_config& sink_config)
4040
: client_{sink_config.server_host, sink_config.server_port} {}
4141

4242
~udp_sink() override = default;

0 commit comments

Comments
 (0)