Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang.org/x/mod for parsing Fyne version in go.mod #5

Open
Jacalz opened this issue Jan 2, 2024 · 3 comments
Open

Use golang.org/x/mod for parsing Fyne version in go.mod #5

Jacalz opened this issue Jan 2, 2024 · 3 comments
Assignees
Labels
fyne command Issue related to the cmd/fyne command

Comments

@Jacalz
Copy link
Member

Jacalz commented Jan 2, 2024

Use https://pkg.go.dev/golang.org/x/mod here:

dependenciesOutput, err := runner.runOutput("mod", "edit", "-json")

@Jacalz Jacalz self-assigned this Jan 2, 2024
@andydotxyz
Copy link
Member

Make sure that whatever library we use it supports the new point release notation for Go since 1.21.0

@Jacalz
Copy link
Member Author

Jacalz commented Jan 3, 2024

I think x/mod is what the compiler uses internally for module parsing. I will be more or less the same as using the Go binary for it.

@andydotxyz
Copy link
Member

Yes, but as noted in the issues in golang GitHub the compiler not matching the toolchain/library is the source of problems elsewhere so it felt important to note.

@Jacalz Jacalz added the fyne command Issue related to the cmd/fyne command label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fyne command Issue related to the cmd/fyne command
Projects
None yet
Development

No branches or pull requests

2 participants