Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If .cache() is called after fully rendered we may have to update the height #40

Open
wilsonpage opened this issue Nov 3, 2015 · 0 comments
Labels

Comments

@wilsonpage
Copy link
Contributor

If the user is using appending chunks pattern and calls .cache() after the finally chunk has fully rendered the height of the list may be incorrect.

This is because we instantly set the fullHeight from the last cache. When we cache next, it an indication that the model is now complete. If this happens before the fastlist.render() it's OK as the cached height will be cleared before the render takes place.

If it's called after the final fastlist.render() then we risk not updating the list height and it could remain locked at the old height.

When the user calls .cache() we should check the calculated height against the list's current actual height and update if they don't match.

@wilsonpage wilsonpage added the bug label Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant