Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical name for OriginRequestPolicy doesn't work for multiple deployed stacks #9

Open
HerrBertling opened this issue Jul 20, 2023 · 0 comments

Comments

@HerrBertling
Copy link

Hey 👋

First of all: Thanks for your awesome work with this repo. I've used it for the second time already and I'm really glad you provided such a nice boilerplate 😊 👍

I ran into an issue with this, though, and I figured I might raise this as a small issue since this has a simple fix from what I understood.

When setting up the cloudfront.OriginRequestPolicy, you're setting a static name for it here. This works well for a single Remix application deployed via this template. As soon as another one gets added in the same account, though, that stack cannot be deployed. Simple reason: There already is the named OriginRequestPolicy.

The simple fix for this would be to "just" remove that line from the stack. Naming is then automagically taken care of and won't break when adding more environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant