Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3d - Lint - linebreak-style for windows #3849

Open
Omria09 opened this issue Oct 29, 2024 · 2 comments
Open

Part 3d - Lint - linebreak-style for windows #3849

Omria09 opened this issue Oct 29, 2024 · 2 comments
Labels
part 3 windows Windows-specific issues

Comments

@Omria09
Copy link

Omria09 commented Oct 29, 2024

Hi!
I noticed that in part3d in the lint part we are asked to add these four style rules:
image
as it turns out, when the user's os is windows and he has the default 'LF' nd of Line Sequence set in his IDE (tested on vscode) the eslint command 'eslint .' will output tons of EOL errors:
image
using the --fix flag is not recommended as stated in this stackoverflow answer: https://stackoverflow.com/questions/37826449/expected-linebreaks-to-be-lf-but-found-crlf-linebreak-style

@Omria09
Copy link
Author

Omria09 commented Oct 29, 2024

Please assign me to this issue 😎👌🔥

@vejol
Copy link
Contributor

vejol commented Jan 3, 2025

Hi @Omria09,

Thank you for your interest in contributing! Unfortunately, we are unable to assign issues to contributors who are not part of the organization. However, you are welcome to fork the repository, work on the issue, and submit a pull request. We will be happy to review it.

@vejol vejol added part 3 windows Windows-specific issues labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part 3 windows Windows-specific issues
Projects
None yet
Development

No branches or pull requests

2 participants