-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read-only tables performance #4
Comments
Step to reproduce JFYI:
|
I thought I hadn't pushed it from a separate repo before.
It was more proof of concept I only tested simple examples work.
The most likely answer is my changes might be causing a bad guard to be emitted that always fails or I might be causing traces to be always aborted for some reason. You can try just the first commit on its own since it only touch the interpreter which in theory should 0 to almost no slowdown. The collocated table size field for marking a table readonly could be getting some weird collision i didn't correctly check for |
Fix C VM events breaking disabled JIT builds
I am very interested in the read-only tables feature. I have seen promising results in a microbenchmark (LuaJIT#248 (comment)) and now I am testing with a real application (Snabb).
Initial scores are low on my simplest Snabb benchmark. Baseline score is 27, merging the readonlytables branch (commit 68515a2) this drops to 7, and adding a couple of calls to
table.setreadonly()
that I expected to be beneficial dropped the score to 0.1. So the opening position is a 270x slowdown and I am keen to improve on this :-)Just quick questions if I may:
readonlytables
the right branch? I also seereadonly_tables
.table.setreadonly()
?Cheers!
The text was updated successfully, but these errors were encountered: