Sets -Wno-error=address-of-packed-member if available #11
Conversation
shinnya
force-pushed
the
fix-gcc9-build-error
branch
3 times, most recently
from
6787608 to
cb3f0c7
Compare
liberasurecode_configure_ac.patch
Outdated
|
|
||
| +# Check if a compiler supports "-Wno-error=address-of-packed-member" | ||
| +# If it supports the option, we add it to CFLAGS. | ||
| +AX_CHECK_COMPILE_FLAG([-Wno-error=address-of-packed-member], |
There was a problem hiding this comment.
AX_CHECK_COMPILE_FLAG requires autoconf-archive package. See https://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html.
| AC_PROG_CC | ||
| AM_PROG_CC_C_O | ||
| + | ||
| +# Check if a compiler supports "-Wno-error=address-of-packed-member" |
There was a problem hiding this comment.
This patch doesn't work on macOS as expected. For example, https://travis-ci.org/shinnya/liberasurecode/jobs/564306690 (removes all cache before this build).
shinnya
force-pushed
the
fix-gcc9-build-error
branch
from
cb3f0c7 to
c1cc1a2
Compare
shinnya
changed the title
| - autoconf | ||
| - autoconf-archive # for AX_CHECK_COMPILE_FLAG | ||
| - automake | ||
| - libtool |
There was a problem hiding this comment.
It seems .travis.yml can't put these package declarations together, so repeats them multiple times.
| - automake | ||
| - libtool | ||
| env: | ||
| - MATRIX_EVAL="CC=gcc-4.9 CXX=g++-4.9" |
There was a problem hiding this comment.
gcc 4.8 と gcc 4.9 は何か目的が異なるのでしょうか。
There was a problem hiding this comment.
gcc 4.8 か 4.9 のどちらかが Scientific Linux 7.2 で使われているのではないかと思いますが、どちらか分からないため両方入れてました。
macOS も XCode のバージョンをどれをメインで使っているのか分からないので、色々入ってます。
あまりにもビルド時間がかかりすぎるので、絞った方がよい気はしています。
There was a problem hiding this comment.
なるほど。
ちなみに Scientific Linux 7 および Cent OS 7 は gcc 4.8 です。
This resolves #10. This PR doesn't become a solution to the root of the problem, so we should update
openstack/liberasurecodeto fix.