Skip to content

Commit fad90c3

Browse files
committed
Update todos
1 parent 4d2ab3d commit fad90c3

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ os:
66
- osx
77
- windows
88

9-
# TODO: Run golangci-lint via Travis
9+
# @todo #0 Run golangci-lint via Travis

Magefile.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ import (
1010
"github.com/magefile/mage/sh"
1111
)
1212

13+
// @todo #0 Get rid of mage and write a bash script ./task that takes an argument
14+
1315
var Default = StampedBuild
1416

1517
func GitRepoIsClean() error {

health.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ var healthConcerns = map[string]healthFunc{
4040
}
4141

4242
const (
43-
// TODO: Make these optionally configurable in the config file.
43+
// @todo #0 Make diskLowThreshold & ytdlOldThreshold customizable in the config file.
4444
diskLowThreshold = 1024 * 1024 * 1024 // 1GB
4545
ytdlOldThreshold = time.Hour * 24 * 60 // 60 days
46-
// TODO: Make this optionally configurable per-podcast in the config file.
46+
// @todo #0 Make feedsStaleThreshold customizable per-podcast in the config file.
4747
feedsStaleThreshold = time.Hour * 24 * 10 // 10 days
4848
)
4949

@@ -81,15 +81,13 @@ func healthHandler(w http.ResponseWriter, r *http.Request) {
8181
type healthFunc func() (bool, error)
8282

8383
func diskLow() (bool, error) {
84-
// TODO(DH): Pass the global `dataPath` as the path to check?
8584
ok := du.NewDiskUsage(".").Available() < diskLowThreshold
8685
return ok, nil
8786
}
8887

8988
func ytdlOld() (bool, error) {
90-
// TODO: Cache this for ... minutes because otherwise requesting /health
91-
// could be a DoS because every request forks a process that takes ~2s to
92-
// run.
89+
// @todo #0 Cache ytdl version output for a while to prevent reqs to /health causing DoS.
90+
// Because each request currently forks the ytdl process that takes ~2s to run.
9391
version, err := exec.Command(downloadCmdName, "--version").Output()
9492
if err != nil {
9593
return false, err

0 commit comments

Comments
 (0)