Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LT 2.0] Add AnnounceEndpoint:swig and peer_info::get_pieces methods #297

Closed
proninyaroslav opened this issue Oct 15, 2024 · 5 comments
Closed

Comments

@proninyaroslav
Copy link
Contributor

proninyaroslav commented Oct 15, 2024

I'm currently migrating my app to jlibtorrent and have encountered a couple of methods that are missing from jlibtorrent:

  • AnnounceEndpoint:swig
  • peer_info::get_pieces

I'm using announce_endpoint to get getLast_error and get_pieces is used to calculate torrent availability and relevance value.
I'll try to figure out swig and maybe I'll be able to add these methods and make a PR.

@aldenml
Copy link
Collaborator

aldenml commented Oct 15, 2024

why... :(

I know I know...lacks of update. Is there something I can do for you keep using libtorrent4j?

@proninyaroslav
Copy link
Contributor Author

@aldenml
Hi. I didn't mean to upset you. I'm very grateful for your work, and I would like you to continue releasing updates, but without updates I don't see any other options. For example,

  1. The problem with bdecode_node hasn't been solved.
  2. Also, since the beginning of 2023, users have started to face mass bans of incoming peers Mass ban of all incoming peers arvidn/libtorrent#7734. I don't know what the reason is, maybe it's fixed in upstream, but without updates from upstream I don't even have a chance to check it.
  3. I would like to have a working posix_wrapper again for SAF, or the ability to write a custom disk_interface to interact with SAF Add an ability to set custom disk_interface aldenml/libtorrent4j#269

@aldenml
Copy link
Collaborator

aldenml commented Oct 15, 2024

@proninyaroslav I understand and I'm also grateful for you picking libtorrent4j early on. The 2) could be difficult to figure out, and yes, maybe that's a problem only in master upstream. Hopefully, I can release an update before you complete the migration :)

@master255
Copy link

On version 1.2 I don't have any problems. Maybe the problem is not bugs, but updates.

@gubatron
Copy link
Collaborator

please send 2 separate PRs, each on a separate feature branch so I can easily test.

Also notice we are now on the libtorrent 2, if this is for 1.2 make sure to create the branch off of the 1.2 branch (which we more likely not be maintaining, volunteers for that branch welcome)

@proninyaroslav proninyaroslav changed the title Add AnnounceEndpoint:swig and peer_info::get_pieces methods [LT 2.0] Add AnnounceEndpoint:swig and peer_info::get_pieces methods Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants