Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https redirect #48

Open
frostschutz opened this issue May 1, 2014 · 3 comments · May be fixed by #57
Open

https redirect #48

frostschutz opened this issue May 1, 2014 · 3 comments · May be fixed by #57
Labels

Comments

@frostschutz
Copy link
Owner

currently the redirect forces users to (not) use https depending on the bburl setting

there should be a setting to make it ignore https status so users can choose themselves whether they want to use https or not.

@frostschutz
Copy link
Owner Author

cloudflare seems to set

[HTTP_X_FORWARDED_PROTO] => https
while
[SERVER_PORT] => 80
etc.

This just doesn't work well. Maybe the redirect should just be relative whenever possible...

@frostschutz
Copy link
Owner Author

For cloudflare in particular there is also [HTTP_CF_VISITOR] => {"scheme":"https"}

@Thomas131
Copy link

This was just creating a redirect loop on my forum ... We just upgraded to use Caddy as a reverse Proxy.
For sure, the PHP-Script thinks that it is an http-Request, even though it is https from the outside ... I think $_SERVER["HTTP_X_FORWARDED_PROTO"] (if set) should be valued more than the internal https-status. I also think that this should be labeled as bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants