Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic when deathnode iterates over already terminated instance #4

Open
frimik opened this issue Aug 29, 2018 · 0 comments
Open

panic when deathnode iterates over already terminated instance #4

frimik opened this issue Aug 29, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@frimik
Copy link
Owner

frimik commented Aug 29, 2018

instance.go:

	return &InstanceMonitor{
		autoscalingGroupID:  autoscalingGroupID,
		ipAddress:           *response.PrivateIpAddress,
		instanceID:          instanceID,
		lifecycleState:      lifecycleState,
		isProtected:         isProtected,
		ctx:                 ctx,
		tagRemovalTimestamp: tagRemovalTimestamp,
	}, nil

in this case, the response.PrivateIpAddress will be nil <*string> and you will panic.

Handle it and finish the lifecycle on this instance if you find that is needed. Otherwise you will continually panic until the instance lifecycle timeout expires (3600 seconds)

@frimik frimik added the bug Something isn't working label Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant