Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mksnapshot binary should be installed to bin/ #14

Open
milahu opened this issue Feb 3, 2023 · 0 comments
Open

mksnapshot binary should be installed to bin/ #14

milahu opened this issue Feb 3, 2023 · 0 comments

Comments

@milahu
Copy link

milahu commented Feb 3, 2023

... no? or maybe libexec/

actual vs expected

-  /bin/linux-x86_64/v8-mksnapshot-linux-x86_64
+  /bin/v8-mksnapshot-linux-x86_64

downstream meson in frida-core says

Program v8-mksnapshot-linux-x86_64 found: NO

workaround:

export PATH=/path/to/frida-v8/bin/linux-x86_64:$PATH

a need for bin_subdir should be documented in a comment

if meson.can_run_host_binaries()
bin_subdir = f'@host_os_frida@-@host_arch_frida@'
else
bin_subdir = f'@build_os_frida@-@build_arch_frida@'
endif
custom_target('mksnapshot-installed',
input: mksnapshot,
output: f'v8-mksnapshot-@host_os_frida@-@host_arch_frida@@bin_extension@',
command: [
post_process_executable,
'--input-file', '@INPUT@',
'--output-file', '@OUTPUT@',
'--strip-option', get_option('strip').to_string(),
'--',
strip,
],
install: true,
install_dir: get_option('bindir') / bin_subdir,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant