Symbolic Service Disposal #80
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
freshgum-bubbles
force-pushed
the
feat/symbolic-dispose
branch
from
740842d
to
f7e3efe
Compare
This commit introduces a new method to the ContainerInstance class: resetValuesLazily. This method returns an iterator which lazily disposes each service in the container. The main advantage of this method is that, for each iteration, it yields both the ID of the service being disposed, alongside a "status" member, which signifies the progress of the service's disposal routine.
This allows classes to implement it.
freshgum-bubbles
force-pushed
the
feat/symbolic-dispose
branch
from
f7e3efe
to
bc31fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability for the container to utilise a service's
Symbol.disposemethod, along withasyncDisposeto dispose of it.A new token, aptly named
DISPOSEis also introduced, which allowsthe caller to prevent the calling of the native, Symbol-based methods,
in favour of a method dedicated to disposing the service when the DI
container tells it to. This allows the service to provide custom handling
for DI-incurred disposals.
Compatibility with the old, string-based
disposemethod API is kept,to prevent breakages in current applications. However, migration away
from this is strongly recommended, as it may cause unexpected behaviour.
Fixes #4.