-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abbility to create custom VLANs to network settings #2907
base: main
Are you sure you want to change the base?
Conversation
the reload fix causes the settings of individual interfaces to not be saved, as they are created too late |
7a0e8e2
to
3eb5964
Compare
This is originally from @lemoer's PR The patch works as-is but the UI is a bit wonky DSA is a hard requirement for all switches, so the existence of swconfig should disable this feature (if there are any non-DSA devices left after 23)
Are there still bugs with this PR? |
Sortof. So the issue is that interfaces don't show up / don't vanish correctly aswell as remove not working which is a circular dependency we can't resolve in the old ui system. There isn't a good solution other than the planned rewrite of the webinterface, which will take a bit longer. If the patchset works for you despite those bugs you can also unoffically use it until then, but since it's not really working how it's supposed to we won't move forward until I get time to get the new frontend part done. |
so if we want to remove an interface we created, we might need to do "firstboot" since it currently doesn't work at all (without the interface rewrite)? |
just removing it from /etc/config/gluon should be enough. btw, it's just the ui. you can copy-paste those vlans on any device with dsa and they will just work. (after reconfigure and without this VLAN ui patch)
|
should or I run |
yes and then gluon-reload (or better reboot) |
This is originally from @lemoer's PR
The patch works as-is but the UI is a bit wonky
DSA is a hard requirement for all switches,
so the existence of swconfig should disable this feature (if there are any non-DSA devices left after 23)
Bugs: