Skip to content

Commit 25bbaab

Browse files
committed
Disable failing not installed and not configured tests
These pass locally for me but fail in the github workflow. Marking as xfail for now. A deprecation warning is being spit out now on stderr instead out stdout which includes the underlying message. Check both stdout and stderr to be on the safe side. Note: these tests only run as root. Related: #309 Signed-off-by: Rob Crittenden <[email protected]>
1 parent bbffe5f commit 25bbaab

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

tests/test_commands.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,35 @@ def _make_facts(configured=None):
4040
return _make_facts
4141

4242

43+
@pytest.mark.xfail(
44+
reason="https://github.com/freeipa/freeipa-healthcheck/issues/309"
45+
)
4346
def test_ipa_notinstalled(python_ipalib_dir, monkeypatch):
4447
"""
4548
Test ipa-healthcheck handles the missing IPA stuff
4649
"""
4750
monkeypatch.setenv("PYTHONPATH", python_ipalib_dir(configured=None))
4851
output = run(["ipa-healthcheck"], raiseonerr=False, env=os.environ)
4952
assert output.returncode == 1
50-
assert "IPA server is not installed" in output.raw_output.decode("utf-8")
53+
assert "IPA server is not installed" in output.raw_output.decode(
54+
"utf-8"
55+
) or "IPA server is not installed" in output.raw_error_output.decode(
56+
"utf-8"
57+
)
5158

5259

60+
@pytest.mark.xfail(
61+
reason="https://github.com/freeipa/freeipa-healthcheck/issues/309"
62+
)
5363
def test_ipa_unconfigured(python_ipalib_dir, monkeypatch):
5464
"""
5565
Test ipa-healthcheck handles the unconfigured IPA server
5666
"""
5767
monkeypatch.setenv("PYTHONPATH", python_ipalib_dir(configured=False))
5868
output = run(["ipa-healthcheck"], raiseonerr=False, env=os.environ)
5969
assert output.returncode == 1
60-
assert "IPA server is not configured" in output.raw_output.decode("utf-8")
70+
assert "IPA server is not configured" in output.raw_output.decode(
71+
"utf-8"
72+
) or "IPA server is not configured" in output.raw_error_output.decode(
73+
"utf-8"
74+
)

0 commit comments

Comments
 (0)