Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark sd-proxy as a service VM so the updater will restart it #1145

Open
1 task done
legoktm opened this issue Jul 10, 2024 · 0 comments · May be fixed by #1146
Open
1 task done

Mark sd-proxy as a service VM so the updater will restart it #1145

legoktm opened this issue Jul 10, 2024 · 0 comments · May be fixed by #1146
Milestone

Comments

@legoktm
Copy link
Member

legoktm commented Jul 10, 2024

  • I have searched for duplicates or related issues

Description

The updater shuts down all VMs with template updates, but only restarts the ones marked as servicevm (usually sys-*), which sd-whonix is.

We should do the same for sd-proxy, which effectively is also a stateless service VM that just provides networking for the client.

Steps to Reproduce

Run the updater, which shuts down sd-proxy. Open the client and log in.

Expected Behavior

Log in request is sent immediately and you log in.

Actual Behavior

Need to wait for sd-proxy to start so the RPC call can fire off the request. If this takes too long (plus tor weather), it's possible the TOTP will expire before the request makes it to the server.

Comments

I assume we can trivially set this via salt.

@rocodes rocodes linked a pull request Jul 11, 2024 that will close this issue
8 tasks
@rocodes rocodes added this to the 1.1.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants