Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to configure max database connections for site database users #2316

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

feat: support to configure max database connections for site database users #2316

wants to merge 14 commits into from

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Nov 29, 2024 •
edited
Loading

Fixes #2315 #2317
(Check issue for more details)

  • Clean up non required fields and functions of old implementation
  • Limit database user's max connection. The total allowed connections for each site will be 16 by default. But upon any request, we can configure it from backend
  • Frontend Changes
  • Allow to set label/title for database user to identify easily (Fixes 2317)

@tanmoysrt tanmoysrt linked an issue Nov 29, 2024 that may be closed by this pull request
feat: limit connections per site db user #2315
Open
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.19%. Comparing base (a3face0) to head (0e82652).

Files with missing lines Patch % Lines
...s/doctype/site_database_user/site_database_user.py 0.00% 9 Missing ⚠️
press/press/doctype/agent_job/agent_job.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
- Coverage   42.19%   42.19%   -0.01%     
==========================================
  Files         376      376              
  Lines       28695    28693       -2     
==========================================
- Hits        12109    12107       -2     
  Misses      16586    16586

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanmoysrt tanmoysrt linked an issue Nov 29, 2024 that may be closed by this pull request
feat: show label for database users and permission manager #2317
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BreadGenie BreadGenie Awaiting requested review from BreadGenie BreadGenie will be requested when the pull request is marked ready for review BreadGenie is a code owner

@balamurali27 balamurali27 Awaiting requested review from balamurali27 balamurali27 will be requested when the pull request is marked ready for review balamurali27 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: show label for database users and permission manager feat: limit connections per site db user
1 participant
@tanmoysrt