-
Notifications
You must be signed in to change notification settings - Fork 160
Description
Description of the issue
Multiline commands break in jobs due to a Flux-related issue.
These multiline commands currently need to be written on a single line to work correctly.
Context information (for bug reports)
While running jobs like create-site, drop-site, etc., which include site commands written as multiline strings using ^, the folded multi-line string gets converted into a normal multi-line string, and additional newlines are added. This causes the commands to break.
Related Flux issue:
fluxcd/helm-controller#383
Even though the above helm-controller issue is closed and claims to have resolved the problem, the issue still persists. Multiline strings continue to break.
This issue was previously fixed for this Helm chart in the following PR:
#130
However, that fix only applies to the config-bench job. All other jobs that use multiline commands are still affected and do not work correctly.
This issue needs to be fixed in the other jobs as well.
Steps to reproduce the issue
- Deploy this Helm chart using a HelmRelease with
createSiteenabled and create a site.
Observed result
- Inspect the
create-sitecommand in the job logs. The command is broken into multiple lines and becomes an invalid command.
Expected result
- The command should execute correctly and the site should be created successfully.
Stacktrace / full error message (if available)
Below are the logs from the drop-site job:
Taking backup of erp.disha.local
set -o pipefail; /usr/bin/mariadb-dump --user=_5d62ffcd4d8f935b --host=erpnext-mariadb-sts --port=3306 --password=********** --single-transaction --quick --lock-tables=false _5d62ffcd4d8f935b | /usr/bin/gzip >> ./erp.disha.local/private/backups/20260127_120441-erp_disha_local-database.sql.gz
Backup Summary for erp.disha.local at 2026-01-27 12:04:43.511633
Config : ./erp.disha.local/private/backups/20260127_120441-erp_disha_local-site_config_backup.json 147.0B
Database: ./erp.disha.local/private/backups/20260127_120441-erp_disha_local-database.sql.gz 866.2KiB
Public : ./erp.disha.local/private/backups/20260127_120441-erp_disha_local-files.tar 10.0KiB
Private : ./erp.disha.local/private/backups/20260127_120441-erp_disha_local-private-files.tar 10.0KiB
Dropping site database and user
Warning: Password input may be echoed.
MySQL root password:
Aborted!
bash: line 3: --db-host=erpnext-mariadb-sts: command not found
bash: line 4: --root-login=: command not found
bash: line 5: --root-password=root-password: command not found
bash: line 6: --archived-sites-path=archived_sites: command not found
bash: line 7: --no-backup: command not found
stream closed: EOF for erpnext/erpnext-drop-site-20260127063439-zghvc (drop-site)