Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #239

Closed
revant opened this issue Mar 2, 2025 · 1 comment · Fixed by #240
Closed

Improve tests #239

revant opened this issue Mar 2, 2025 · 1 comment · Fixed by #240

Comments

@revant
Copy link
Collaborator

revant commented Mar 2, 2025 •
edited
Loading

Thanks for your fix. As far as I tested, that did the trick! Very delightful. I would still suggest being a little more careful about what goes into production. I'm aware mistakes happen 😉 and we are all humans. First thought it's my custom helm values and after several hours, I discovered that it was not even my fault. 😶‍🌫️

Originally posted by @codefuturist in #235

I merged when it was green.

Everything okay here https://github.com/frappe/helm/pull/233/checks

Test did fail! Somehow didn't trigger non 0 exit.
revant added a commit to revant/frappe-helm that referenced this issue Mar 2, 2025
@revant
fix: tests
b23a46b 
fail on first error

fixes frappe#239
@revant revant mentioned this issue Mar 2, 2025
Merged
@revant
Copy link
Collaborator Author

revant commented Mar 2, 2025

Now it fails as expected here https://github.com/frappe/helm/actions/runs/13615290929/job/38057581217

revant added a commit that referenced this issue Mar 3, 2025
@revant
fix: tests (#240)
1f34e39 
fail on first error

fixes #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tests revant/frappe-helm
1 participant
@revant