New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Data Should be Computed in Backend to Maintain Consistent Behaviour #44195

Open

Ninad1306 wants to merge 2 commits into frappe:develop from Ninad1306:growth_view_fix

+83 −21

Contributor

Ninad1306 commented Nov 18, 2024 •

edited

Loading

In Profit and Loss Statement and Balance Sheet Report the data for growth view and margin view is calculated in frontend.
Due to which there is inconsistent behaviour while exporting the data.


          fix: growth view data should be computed in backend

0071ee5

Ninad1306 requested review from deepeshgarg007 and ruthra-kumar as code owners

November 18, 2024 13:20

github-actions bot added the needs-tests label

Ninad1306 marked this pull request as draft

November 18, 2024 13:26


          fix: margin view data should be computed in backend

4f5ad62

Ninad1306 marked this pull request as ready for review

November 21, 2024 07:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels