Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation choice about player and box #3

Open
ranska opened this issue Feb 25, 2017 · 0 comments
Open

Implementation choice about player and box #3

ranska opened this issue Feb 25, 2017 · 0 comments

Comments

@ranska
Copy link

ranska commented Feb 25, 2017

I understand and appreciate the simple choice of mixing player and box.
But it could be interesting to provide a 2nd implementation with player and box
separated.
This 2nd implementation can be motivated and justify by a chapter 2
who can have a purpose of introduce "adding new module on existing"
with a feature pretext like "player can write their name at the beginning".

It will force to replace A B by X O and show player name.
And introduce on reflexion about how to deal with increase of complexity.

What do think about ? Is It too far from the initial purpose or do you like it ?

franckverrot added a commit that referenced this issue Feb 26, 2017
\#3 brings up a good observation: boxes and players were mixed to make
things simple, but at hinsight it is not obvious to me it was a good
idea.  This commit dissociates these.

Also, boxes don't need to know their positioning, only the `Clicked`
event should know what's going on and determine which box has been
clicked based on the index it's been given.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant