Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long commands won't return in a root shell on macOS #149

Open
melomac opened this issue Jul 8, 2024 · 0 comments
Open

Long commands won't return in a root shell on macOS #149

melomac opened this issue Jul 8, 2024 · 0 comments

Comments

@melomac
Copy link

melomac commented Jul 8, 2024

On running long commands as effective user root (ex: sudo su -), with current fish and current macOS, an error in terminal-notifier prevents the command to terminate properly.

Note this isn't specific to done, but to terminal-notifier, ex:

echo pipo | terminal-notifier 
2024-07-08 04:53:49.446 terminal-notifier[25427:6912759] NSNotificationCenter connection invalid
^C⏎

^^ won't return until I hit ⌃ C too.

Would you mind considering either:

  1. providing a global flag for users to "temporary" disable done, ex with ~root/.config/fish/config.fish:
if functions -q fish_is_root_user; and fish_is_root_user
    set -e __done_enabled
end

^^ this didn't do the trick

PS: on macOS, a quick way to figure out current logged in username is: stat -f "%Su" /dev/console or user id: stat -f "%u" /dev/console.

  1. disable by default done when effective user isn't a logged in user, i.e. when it doesn't make sense to stack notifications?

Many thanks for done 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant