Skip to content

Commit 9c160c8

Browse files
committed
Fix database selection jumpy state
Signed-off-by: Cédric Boirard <[email protected]>
1 parent 19f8899 commit 9c160c8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

examples/cms/src/App.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import "./App.css"
33
import type { ManagedCollection } from "framer-plugin"
44

55
import { framer } from "framer-plugin"
6-
import { useEffect, useLayoutEffect, useState } from "react"
6+
import { useEffect, useState } from "react"
77
import { DataSource, getDataSource } from "./data"
88
import { FieldMapping } from "./FieldMapping"
99
import { SelectDataSource } from "./SelectDataSource"
@@ -17,19 +17,19 @@ interface AppProps {
1717

1818
export function App({ collection, previousDataSourceId, previousSlugFieldId }: AppProps) {
1919
const [dataSource, setDataSource] = useState<DataSource | null>(null)
20-
2120
const [isLoadingDataSource, setIsLoadingDataSource] = useState(Boolean(previousDataSourceId))
22-
const hasDataSourceSelected = Boolean(isLoadingDataSource || dataSource)
2321

24-
useLayoutEffect(() => {
22+
useEffect(() => {
23+
const hasDataSourceSelected = Boolean(dataSource)
24+
2525
framer.showUI({
2626
width: hasDataSourceSelected ? 360 : 320,
2727
height: hasDataSourceSelected ? 425 : 305,
2828
minWidth: hasDataSourceSelected ? 360 : undefined,
2929
minHeight: hasDataSourceSelected ? 425 : undefined,
30-
resizable: dataSource !== null,
30+
resizable: hasDataSourceSelected,
3131
})
32-
}, [hasDataSourceSelected, dataSource])
32+
}, [dataSource])
3333

3434
useEffect(() => {
3535
if (!previousDataSourceId) {

0 commit comments

Comments
 (0)