File tree Expand file tree Collapse file tree 6 files changed +10
-10
lines changed
Expand file tree Collapse file tree 6 files changed +10
-10
lines changed Original file line number Diff line number Diff line change 99 reasons] .
1010- Don't use the ` jQuery ` or ` $ ` global. Access jQuery via ` angular.element ` .
1111
12- [ avoid manual dependency annotations ] : http://robots. thoughtbot.com/avoid-angularjs-dependency-annotation-with-rails
12+ [ avoid manual dependency annotations ] : http://thoughtbot.com/blog /avoid-angularjs-dependency-annotation-with-rails
1313[ ngannotate ] : https://github.com/kikonen/ngannotate-rails
1414[ performance reasons ] : https://github.com/angular-translate/angular-translate/wiki/Getting-Started#using-translate-directive
Original file line number Diff line number Diff line change 66 mailer view before merging. Use [ MailView] gem unless using Rails version
77 4.1.0 or later.
88
9- [ amazon ses ] : http ://robots. thoughtbot.com/post/3105121049/delivering -email-with-amazon-ses-in-a-rails-3 -app
9+ [ amazon ses ] : https ://thoughtbot.com/blog/deliver -email-with-amazon-ses-in-a-rails-app
1010[ sendgrid ] : https://devcenter.heroku.com/articles/sendgrid
1111[ mailview ] : https://github.com/37signals/mail_view
1212[ actionmailer preview ] : http://api.rubyonrails.org/v4.1.0/classes/ActionMailer/Base.html#class-ActionMailer::Base-label-Previewing+emails
Original file line number Diff line number Diff line change 1010 exceeds 100 lines, it may be doing too many things.
1111- [ Tell, don't ask] .
1212
13- [ tell, don't ask ] : https://robots. thoughtbot.com/tell-dont-ask
13+ [ tell, don't ask ] : https://thoughtbot.com/blog /tell-dont-ask
Original file line number Diff line number Diff line change 7575- [ Add foreign key constraints] in migrations.
7676
7777[ `on_delete` behavior for foreign keys ] : http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_foreign_key
78- [ add foreign key constraints ] : http://robots. thoughtbot.com/referential-integrity-with-foreign-keys
78+ [ add foreign key constraints ] : http://thoughtbot.com/blog /referential-integrity-with-foreign-keys
7979
8080## Routes
8181
9999- Use the user's name in the ` From ` header and email in the ` Reply-To ` when
100100 [ delivering email on behalf of the app's users] .
101101
102- [ delivering email on behalf of the app's users ] : http://robots. thoughtbot.com/post/3215611590/recipe- delivering-email-on-behalf-of-users
102+ [ delivering email on behalf of the app's users ] : http://thoughtbot.com/blog/ post/delivering-email-on-behalf-of-users
103103
104104## Code Review
105105
Original file line number Diff line number Diff line change 6767- Use an [ exact version] in the ` Gemfile ` for fragile gems, such as Rails.
6868
6969[ ruby version ] : http://bundler.io/v1.3/gemfile_ruby.html
70- [ exact version ] : http://robots. thoughtbot.com/post/35717411108 /a-healthy-bundle
71- [ pessimistic version ] : http://robots. thoughtbot.com/post/35717411108 /a-healthy-bundle
72- [ versionless ] : http://robots. thoughtbot.com/post/35717411108 /a-healthy-bundle
70+ [ exact version ] : http://thoughtbot.com/blog /a-healthy-bundle
71+ [ pessimistic version ] : http://thoughtbot.com/blog /a-healthy-bundle
72+ [ versionless ] : http://thoughtbot.com/blog /a-healthy-bundle
7373
7474## Ruby Gems
7575
Original file line number Diff line number Diff line change 3636[ `allow` syntax ] : https://github.com/rspec/rspec-mocks#method-stubs
3737[ dependency injection ] : http://en.wikipedia.org/wiki/Dependency_injection
3838[ `delayed::job` matcher ] : https://gist.github.com/3186463
39- [ stubs and spies ] : http://robots. thoughtbot.com/post/159805295 /spy-vs-spy
39+ [ stubs and spies ] : http://thoughtbot.com/blog /spy-vs-spy
4040[ assertions about state ] : https://speakerdeck.com/skmetz/magic-tricks-of-testing-railsconf?slide=51
41- [ fake ] : http://robots. thoughtbot.com/post/219216005 /fake-it
41+ [ fake ] : http://thoughtbot.com/blog /fake-it
4242[ sut ] : http://xunitpatterns.com/SUT.html
4343
4444## Acceptance Tests
You can’t perform that action at this time.
0 commit comments